-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix cache-hit check #2186
ci: fix cache-hit check #2186
Conversation
According to the actions/cache docs an empty string represents a cache miss: > cache-hit - A string value to indicate an exact match was found for the key. > - If there's a cache hit, this will be 'true' or 'false' to indicate if there's an exact match for key. > - If there's a cache miss, this will be an empty string. https://github.com/actions/cache?tab=readme-ov-file#outputs Previously Neqo's CI would check for `"false"`, now it checks for `""`.
See actions/cache#1467 for more details on the regression. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 112 112
Lines 36373 36373
=======================================
Hits 34697 34697
Misses 1676 1676 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
According to the actions/cache docs an empty string represents a cache miss:
https://github.com/actions/cache?tab=readme-ov-file#outputs
Previously Neqo's CI would check for
"false"
, now it checks for""
.Fixes #2185.